Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schedulers: enable transfer-witness-leader by default #5883

Merged
merged 1 commit into from
Jan 30, 2023
Merged

schedulers: enable transfer-witness-leader by default #5883

merged 1 commit into from
Jan 30, 2023

Conversation

ethercflow
Copy link
Member

@ethercflow ethercflow commented Jan 30, 2023 •
edited
Loading

ref #5638

Signed-off-by: Wenbo Zhang ethercflow@gmail.com

What problem does this PR solve?

It is very unfriendly to let the user manually enable this scheduler, it has no effect if witness is not supported.

Issue Number: ref #5638

What is changed and how does it work?

enable transfer-witness-leader by default

Check List

Tests

  • Unit test
  • Integration test
  • Manual test

Code changes

  • None

Side effects

  • None

Related changes

  • None

Release note

None

@ethercflow
schedulers: enable transfer-witness-leader by default
13840a9 
ref tikv#5638

Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 30, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 30, 2023
@ethercflow ethercflow mentioned this pull request Jan 30, 2023
Open
3 tasks
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 75.72% // Head: 75.67% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (13840a9) compared to base (c55e632).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5883      +/-   ##
==========================================
- Coverage   75.72%   75.67%   -0.05%     
==========================================
  Files         342      342              
  Lines       34828    34828              
==========================================
- Hits        26373    26356      -17     
- Misses       6213     6224      +11     
- Partials     2242     2248       +6
Flag Coverage Δ
unittests 75.67% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/config/config.go 78.71% <ø> (ø)
pkg/id/id.go 86.44% <0.00%> (-6.78%) ⬇️
server/storage/storage.go 67.30% <0.00%> (-3.85%) ⬇️
server/schedule/labeler/labeler.go 76.77% <0.00%> (-2.59%) ⬇️
server/tso/allocator_manager.go 62.90% <0.00%> (-1.94%) ⬇️
server/region_syncer/client.go 85.07% <0.00%> (-1.50%) ⬇️
server/cluster/coordinator.go 71.59% <0.00%> (-0.76%) ⬇️
server/schedule/checker/rule_checker.go 80.95% <0.00%> (-0.74%) ⬇️
server/tso/tso.go 69.66% <0.00%> (-0.57%) ⬇️
server/cluster/unsafe_recovery_controller.go 78.36% <0.00%> (-0.35%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 30, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 30, 2023
@nolouch
Copy link
Contributor

nolouch commented Jan 30, 2023

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 13840a9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 30, 2023
@ti-chi-bot ti-chi-bot merged commit 62a7452 into tikv:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@bufferflies bufferflies bufferflies approved these changes

@disksing disksing Awaiting requested review from disksing

@rleungx rleungx Awaiting requested review from rleungx

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ethercflow @ti-chi-bot @nolouch @bufferflies